Skip to content

Onboard C# Intellisense page to Unified Settings#71780

Merged
Cosifne merged 47 commits intodotnet:mainfrom
Cosifne:dev/shech/UnifiedSettings0
Feb 13, 2024
Merged

Onboard C# Intellisense page to Unified Settings#71780
Cosifne merged 47 commits intodotnet:mainfrom
Cosifne:dev/shech/UnifiedSettings0

Conversation

@Cosifne
Copy link
Member

@Cosifne Cosifne commented Jan 23, 2024

This is based on: Prerequisite: #71777 Done

Onboard C# Intellisense page to Unified Settings. Once this is in, I can bring another PR to check the VB side settings in (would be very simple once this is in).

How it looks like:
image

Note: The *;..\Microsft.VisualStudio.LanguagesService.dll is a known bug in the platform. They will fix it soon.

Updates: Find another bug in platform, so keep this as a draft until https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/523746 is checked in

@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 23, 2024
@CyrusNajmabadi
Copy link
Contributor

What are these:
image

@CyrusNajmabadi
Copy link
Contributor

What is this:

image

@@ -0,0 +1,226 @@
{
"properties": {
"textEditor.csharp.intellisense.triggerCompletionOnTypingLetters": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be made more concise without losing descriptive power? I suggest replacing triggerCompletionOnTypingLetters with completeOnTyping. Or is the "letters" part important?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internally we have another option called triggerCompletionOnTyping

public static readonly PerLanguageOption2<bool> TriggerOnTyping = new("dotnet_trigger_completion_on_typing", CompletionOptions.Default.TriggerOnTyping, group: s_completionOptionGroup);

So this is called 'triggerCompletionOnTypingLetters' to avoid the misunderstanding.

}
},
// CompletionOptionsStorage.SnippetsBehavior
"textEditor.csharp.intellisense.snippetsBehavior": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snippets changes look good to me
@genlu @sharwell do you have any concerns?

@@ -0,0 +1,246 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this file should be part of the MS.VS.LanguageServcie.CSharp project

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be deployed under /UnifiedSettings. Is this possible to do it if put under MS.VS.LanguageServcie.CSharp? We can address later if it's needed

@Cosifne Cosifne merged commit 892d5f0 into dotnet:main Feb 13, 2024
@Cosifne Cosifne deleted the dev/shech/UnifiedSettings0 branch February 13, 2024 02:01
@ghost ghost added this to the Next milestone Feb 13, 2024
@jjonescz jjonescz modified the milestones: Next, 17.10 P2 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants