Onboard C# Intellisense page to Unified Settings#71780
Merged
Cosifne merged 47 commits intodotnet:mainfrom Feb 13, 2024
Merged
Conversation
…ause it's not in experiment
Contributor
Contributor
sharwell
reviewed
Jan 26, 2024
sharwell
reviewed
Jan 26, 2024
| @@ -0,0 +1,226 @@ | |||
| { | |||
| "properties": { | |||
| "textEditor.csharp.intellisense.triggerCompletionOnTypingLetters": { | |||
Contributor
There was a problem hiding this comment.
Can this be made more concise without losing descriptive power? I suggest replacing triggerCompletionOnTypingLetters with completeOnTyping. Or is the "letters" part important?
Member
Author
There was a problem hiding this comment.
Internally we have another option called triggerCompletionOnTyping
So this is called 'triggerCompletionOnTypingLetters' to avoid the misunderstanding.
…ne/roslyn into dev/shech/UnifiedSettings0
akhera99
reviewed
Jan 29, 2024
| } | ||
| }, | ||
| // CompletionOptionsStorage.SnippetsBehavior | ||
| "textEditor.csharp.intellisense.snippetsBehavior": { |
Member
sharwell
approved these changes
Jan 30, 2024
genlu
reviewed
Feb 6, 2024
| @@ -0,0 +1,246 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
It feels like this file should be part of the MS.VS.LanguageServcie.CSharp project
Member
Author
There was a problem hiding this comment.
It needs to be deployed under /UnifiedSettings. Is this possible to do it if put under MS.VS.LanguageServcie.CSharp? We can address later if it's needed
genlu
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is based on: Prerequisite: #71777DoneOnboard C# Intellisense page to Unified Settings. Once this is in, I can bring another PR to check the VB side settings in (would be very simple once this is in).
How it looks like:

Note: The *;..\Microsft.VisualStudio.LanguagesService.dll is a known bug in the platform. They will fix it soon.Updates: Find another bug in platform, so keep this as a draft until
https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/523746 is checked in